Fix lost control of new server created on whmcs 8.1.x #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open use count to use check return by ->get() vultr#101
jazz7381 use count to use check return by ->get()
jazz7381 use count to use check return by ->get()
start on converting api to v2
refactored most all of the api up to line 742
More refactoring work done
Tested and corrected alot of functions based on testing the API. Refactored app_list and some others to match the old format response wise with hopes this will make things work smoothly when transitioning to V2 API as the data should be more like the old expected format.and require less refactoring.
bump version
|
@whattheserver I'm not sure if anyone from Vultr is still monitoring this repo. Are your changes in your fork on master? I might give it a go. |
|
@miguemely correct see new tagged release i made for this : |
|
Thank you very much for the work you've put into this, it's very appreciated. |
|
i have try use this update, but tblerrorlog in mysql still added every time, and make to many log DB
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated all deprecated
//use Illuminate\Database\Capsule\Manager as Capsule;To:
use WHMCS\Database\Capsule;As recommended by WHMCS.
https://developers.whmcs.com/advanced/db-interaction/
Fixes Related Issues
#88
#91
#92
#105
#106
Tested with latest
WHMCS Version: 8.1.3
PHP 7.3 and PHP7.4
Centos 7
Please NOTE: That i have incorporated some, but NOT all of the fixes from #101
All original credit for those things should be attributed to @jazz7381 and that PR could most likely be closed as mine incoporates the working stuff from there and more.
Also included is a pretty extensive port of the VultrAPI class to V2 which is not in use yet but is pretty close to being able to be used.
It would be nice if this could be merged here in the official repository so it gets better attention from those in need of it vs hunting through forks and having to pick and pull the needed fixes.
The main issue appears to have been in addVMCustomFields where it was failing to add the subid to tblcustomfieldsvalues
meramsey@453c76e
This in turn causes the creation to fail and allows customers to keep trying to create servers they thought failed but are detached from the client area and costing the Reseller money and time wasted going to clean those up and reattaching only one to the account manually.
Feel free to remove the debugging commented out stuff before merging it was left to make it easier to see what was happening and so the behaviour can be reproduced and tested if desired.
Checklist: