Add a "remove prefix" option to record deletes #4204
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `--rm-prefix` option that will remove a prefix from identifiers. For example, given an identifier of `KOHA-OAI-TEST:2752849` then using `--rm-prefix KOHA-OAI-TEST:` will result in `2752849` as an identifier passed to Solr to be removed.
demiankatz
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Looks like a composer fix might get the build passing here.
We'll also probably want to update the test class to cover the new feature.
Please let me know when you're ready for me to take a closer look at this -- since it's marked Draft, I haven't studied it too closely yet.
|
Will do. I wanted to make this PR draft so I could show the library what I was doing. Will clean up later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--rm-prefixoption that will remove a prefix from identifiers. For example, given an identifier ofKOHA-OAI-TEST:2752849then using--rm-prefix KOHA-OAI-TEST:will result in2752849as an identifier passed to Solr to be removed.