[VUFIND-1741] Remove bootstrap3, bootprint3 and sandal themes #4192
Conversation
There was a problem hiding this comment.
Thanks for all the work on this, @EreMaijala -- looking good so far, but see below for a few minor suggestions and comments.
| "watch:less": "grunt watch:less", | ||
| "build-dev:less": "grunt lessdev && npm run lessToSass", | ||
| "watch-dev:less": "grunt watch:lessdev", | ||
| "build:css": "npm run build:scss", |
There was a problem hiding this comment.
Since we're ripping a bunch of stuff out here, we should update the npm wiki page accordingly. I've added a TODO checkbox for the task. I'm not sure if it's best to keep existing documentation but flag things as deprecated/removed, or to fully simplify it. I guess we should probably maintain some legacy documentation for a while, though my gut just wants to get rid of it quickly. :-)
| * | ||
| * @return string | ||
| * | ||
| * @SuppressWarnings(PHPMD.UnusedLocalVariable) | ||
| */ | ||
| protected function makeRelative($css, $less) | ||
| protected function makeRelative($css, $scss) |
There was a problem hiding this comment.
As far as I can tell, this method is never used. Should we just remove it, or am I missing something?
| ; sandal = bootstrap3 theme with a "flat" styling applied (a newer look | ||
| ; than bootprint3). | ||
| theme = bootprint3 | ||
| ; bootstrap5 = HTML5 theme using Bootstrap 5 with minimal styling. |
There was a problem hiding this comment.
Rather than updating all of these test fixtures, I wonder if we should try to reduce them to contain less information, so they only cover the things we're actually testing. What do you think? I'm open to trying to help with that if you'd like me to!
| @@ -65,7 +65,6 @@ | |||
| <property name="solr_pid_file" value="${localdir}/solr-${solr_port}.pid" /> | |||
| <property name="marc_bib_dir" value="${srcdir}/tests/data" /><!-- directory containing MARC bib records for test environment --> | |||
| <property name="marc_authority_dir" value="${marc_bib_dir}/authority" /><!-- directory containing MARC authority records for test environment --> | |||
| <property name="bootstrap3_theme" value="bootstrap3" /><!-- base Bootstrap 3 theme (used for theme update tasks) --> | |||
| <property name="bootstrap5_theme" value="bootstrap5" /><!-- base Bootstrap 5 theme (used for theme update tasks) --> | |||
There was a problem hiding this comment.
We can also delete the bootstrap5_theme property; it's only used by tasks that have now been removed.
TODO