Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better indexes in login_token table. #4191

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

EreMaijala
Copy link
Contributor

@EreMaijala EreMaijala commented Jan 20, 2025

The new indexes better match the queries improving database efficiency.

TODO

  • Update changelog when merging

The new indexes better match the queries improving database efficiency.
@EreMaijala EreMaijala requested a review from demiankatz January 20, 2025 09:42
@EreMaijala
Copy link
Contributor Author

Postgresql changes tested too!

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small naming nitpick...

module/VuFind/sql/mysql.sql Outdated Show resolved Hide resolved
@demiankatz demiankatz added this to the 11.0 milestone Jan 20, 2025
@EreMaijala EreMaijala requested a review from demiankatz January 22, 2025 07:51
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @EreMaijala.

@demiankatz demiankatz merged commit b70ee00 into vufind-org:dev Jan 22, 2025
6 checks passed
@demiankatz demiankatz deleted the dev-login-token-table-keys branch January 22, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants