Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): avoid scopeId double inheritance when recursing components #12175

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yangxiuxiu1115
Copy link
Contributor

fix #12159
Doesn't look like a good solution, but I couldn't think of one.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 14, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12175

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12175

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12175

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12175

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12175

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12175

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12175

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12175

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12175

vue

pnpm add https://pkg.pr.new/vue@12175

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12175

commit: 672e1cf

@edison1105 edison1105 changed the title fix(ssr): avoid scopeId inheritance when recursing components fix(ssr): avoid scopeId double inheritance when recursing components Oct 14, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: ssr 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Oct 14, 2024
@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Oct 15, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant failure success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success failure
vuetify success success
vueuse success success
vue-simple-compiler success success

@vue-bot
Copy link
Contributor

vue-bot commented Oct 15, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success failure
vuetify success success
vueuse success success
vue-simple-compiler success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: ssr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scoped styles on a recursive component creates duplicate data-v- attribute
3 participants