Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change Components & Libraries order #4177

Closed
wants to merge 14 commits into from

Conversation

warmthsea
Copy link
Contributor

@warmthsea warmthsea commented May 25, 2024

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Fix
  • Feature

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • Title as described
  • Make sure you put things in the right category!
  • Always add your items to the end of a list

Open Source

  • Link description does not contain a link to an author / third-party resource
  • The documentation (README) contains a description of the project, illustration of the project with a demo or screenshots and a CONTRIBUTING section
  • The documentation is in English.
  • The project is active and maintained.
  • The project accepts contributions.
  • Not a commercial product

Apps/Websites

  • The website is available without errors or ssl certificate problems, and load in a reasonable amount of time.
  • The website is using vuejs intensively. It should detect vue with vue-devtools.

    If you cannot detect vue with vue-devtools due to work at non public pages (e.g. for enterprise website), you can send Pull Request with screenshot that detected it.

  • The website is original and not too simple. For that reason, blogs and simple landing pages are rejected.
  • A commercial product using Vue, provided that guests could reasonably check out how Vue was used (i.e. A headless CMS which uses Vue for the Admin/editor Area and offers a free tier).

Copy link
Contributor Author

@warmthsea warmthsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed the order.

Old order:

UI Components
UI Layout
Frameworks

New order:

Frameworks
UI Layout
UI Components

reason:

UI Components
The content menu list is too long, the other two are shorter.

The first choice for most users is the framework, The old sorting makes it difficult for users to see.

@Jogai
Copy link
Collaborator

Jogai commented May 25, 2024

Thanks. Can you maybe rebase? It has a lot of commits and that seems unnecessary.

@warmthsea
Copy link
Contributor Author

Agreed, not necessary for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants