Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make debug tunnel opt-in #1199

Closed
wants to merge 2 commits into from
Closed

Make debug tunnel opt-in #1199

wants to merge 2 commits into from

Conversation

arturpimentel
Copy link
Collaborator

What is the purpose of this pull request?

Change toolbelt default behavior so it does not automatically create debug tunnels using websocket

What problem is this solving?

WebSocket support is currently blocking an important infrastructure
migration in VTEX IO. We'll make this an opt-in feature so that we can
better know if people actually depend on this to do their day-to-day
debugging work.

How should this be manually tested?

  1. yarn link;
  2. vtex link {{app}} -> should link an app without creating a debug tunnel;
  3. vtex link {{app}} --debug -> should link an app creating a debug tunnel'.

Screenshots or example usage

None

Types of changes

  • Refactor (non-breaking change that only makes the code better)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Chores checklist

  • Update CHANGELOG.md

WebSocket support is currently blocking an important infrastructure
migration in VTEX IO. We'll make this an opt-in feature so that we can
better know if people actually depend on this to do their day-to-day
debugging work.
@arturpimentel arturpimentel deleted the feature/debug-flag branch October 30, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant