Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization Support #65

Closed
wants to merge 2 commits into from
Closed

Conversation

ManicMeerkat
Copy link

I needed to localize WinSparkle into 8 languages (with more on the way). The project was set up such that the main application was written in C++/CLI with all localized strings come from a .NET resource DLL. In order to provide as much flexibility for translations and keep all the localized strings in the same place to maintain the localization workflow, I added the following method to the WinSparkle API:

void win_sparkle_set_localized_string(WinSparkleStringID stringID, const wchar_t* localized)

where WinSparkleStringID is an enum found in the new stringids.h, and which corresponds to a UI element.

The client will call win_sparkle_set_localized_string() for each WinSparkleStringID for which it has a translation. If the client doesn't provide a translation, the default English string will be used.

@vslavik
Copy link
Owner

vslavik commented May 28, 2015

The client will call win_sparkle_set_localized_string() for each WinSparkleStringID for which it has a translation.

WinSparkle uses wxWidgets, which already has a sane i18n interface — gettext (see also #35). Any solution that uses string tables of all things, requires tons of hardcoded API calls to set strings, doesn’t bundle translations with WinSparkle itself isn’t acceptable. This is just not a good approach from the technical POV.

I won’t be merging this, sorry.

@vslavik vslavik closed this May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants