Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kafka decision #96

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add Kafka decision #96

wants to merge 4 commits into from

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Apr 11, 2024 •
edited
Loading

Summary

  • Add decision for Kafka
  • Fix some headers in the Keycloak decision
  • Add Keycloak decision to the nav

Checklist

  • Try to isolate changes into separate PRs (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    change, decision, requirement/quality, requirement/functional, dependency
    as they show up in the changelog
  • Link this PR to related issues if applicable.

@Kidswiss Kidswiss added the decision A decision that changes the architecture label Apr 11, 2024
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team April 11, 2024 09:48
@zugao
Copy link
Contributor

zugao commented Apr 11, 2024

We have to discuss this, I propose to do it after our daily tomorrow.

@Kidswiss Kidswiss requested a review from tobru April 11, 2024 09:54
@Kidswiss
Copy link
Contributor Author

We have to discuss this, I propose to do it after our daily tomorrow.

We usually discuss decisions during the backlog refinement.

@zugao
Copy link
Contributor

zugao commented Apr 11, 2024

We have to discuss this, I propose to do it after our daily tomorrow.

We usually discuss decisions during the backlog refinement.

THen backlog refinement it is :)

@Kidswiss
Copy link
Contributor Author

We have to discuss this, I propose to do it after our daily tomorrow.

We usually discuss decisions during the backlog refinement.

THen backlog refinement it is :)

But please have a look until then and add your thoughts.

@Kidswiss Kidswiss marked this pull request as draft April 12, 2024 09:35
@Kidswiss
Copy link
Contributor Author

As discussed with @tobru, on hold for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobru tobru tobru left review comments

Assignees
No one assigned
Labels
decision A decision that changes the architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kidswiss @zugao @tobru