Make connection details split cluster compatible #296
+436
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Kidswiss
changed the title
Kidswiss
force-pushed
the
change/fix_connection_details
branch
from
f61c841 to
e61b85b
Compare
Kidswiss
changed the title
|
I still need to do some cleanup, but the code is ready for review. |
Kidswiss
requested review from
a team,
TheBigLee,
wejdross and
zugao
and removed request for
a team
With this change we ensure that we never reference an instnace namespace directly in the connection details. Instead we hard code it to the Crossplane namespace. Then there's a new function in the runtime that will check each managed resource for connection details, if it's set, it will automatically create a secret in the instance namespace on the service cluster via the provider-kubernetes. There's an annaotation that can be set on the managed resources to disable this functionality for specific resources.
This will make sure that no KubeOptions are dropped, if the object gets read and re-applied to the desired state at any point any function. The implmentation will also ensure that the options are applied in the same order they are applied from the calling functions.
Kidswiss
force-pushed
the
change/fix_connection_details
branch
from
e61b85b to
06c88d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this change we ensure that we never reference an instnace namespace directly in the connection details. Instead we hard code it to the Crossplane namespace. Then there's a new function in the runtime that will check each managed resource for connection details, if it's set, it will automatically create a secret in the instance namespace on the service cluster via the provider-kubernetes.
There's an annotation that can be set on the managed resources to disable this functionality for specific resources.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog