fix: Element editor height

vriteio · Oct 12, 2023 · 5d9b954 · 5d9b954
1 parent d813d5a
commit 5d9b954
Showing 1 changed file with 15 additions and 21 deletions.
diff --git a/apps/web/src/lib/editor/extensions/element-menu/editor.tsx b/apps/web/src/lib/editor/extensions/element-menu/editor.tsx
@@ -178,7 +178,7 @@ const ElementMenuEditor = lazy(async () => {
 
           if (element) {
             element.textContent = codeEditor.getValue() || "";
-            element.style.height = `${codeEditor.getContentHeight()}px`;
+            element.style.minHeight = `${codeEditor.getContentHeight()}px`;
           }
         });
         codeEditor.onDidBlurEditorText(async () => {
@@ -210,26 +210,20 @@ const ElementMenuEditor = lazy(async () => {
         createEffect(
           on(
             () => props.state.active,
-            (active, _, prevElement) => {
-              const element: HTMLElement | null =
-                (prevElement as HTMLElement) ||
-                (document.querySelector(".selected-element-tag") as HTMLElement);
-
-              if (element) {
-                setTimeout(() => {
-                  if (active) {
-                    element.style.height = `${codeEditor.getContentHeight()}px`;
-
-                    return element;
-                  } else {
-                    element.style.height = "unset";
-
-                    return null;
-                  }
-                }, 0);
-              }
-
-              return element || null;
+            (active) => {
+              setTimeout(() => {
+                const element: HTMLElement | null = document.querySelector(
+                  ".selected-element-tag"
+                ) as HTMLElement;
+
+                if (!element) return;
+
+                if (active) {
+                  element.style.minHeight = `${codeEditor.getContentHeight()}px`;
+                } else {
+                  element.style.minHeight = "unset";
+                }
+              }, 200);
             }
           )
         );