add support for journal upload and remote server #482
Conversation
trefzer
force-pushed
the
dev_journal
branch
11 times, most recently
from
63ef53f to
1b6d0aa
Compare
trefzer
force-pushed
the
dev_journal
branch
3 times, most recently
from
8da8aa9 to
30089e6
Compare
|
added journal-remote setting to this merge request to avoid merge conflicts. |
trefzer
changed the title
trefzer
force-pushed
the
dev_journal
branch
3 times, most recently
from
5a5adb1 to
bd778d5
Compare
trefzer
force-pushed
the
dev_journal
branch
7 times, most recently
from
8faafca to
e277b93
Compare
trefzer
force-pushed
the
dev_journal
branch
4 times, most recently
from
b1facf8 to
92caaba
Compare
|
You'll probably need to change the acceptance tests to use Vagrant instead of the default of Docker for systemd to work correctly. |
|
@basterfreak thanks, all done |
|
@kenyon probably, but no idea howto do so ! |
Reason: equal options in journal-upload and journal-remote
| assert_private() | ||
|
|
||
| if $package_name { | ||
| stdlib::ensure_packages($package_name) |
There was a problem hiding this comment.
IMO if the management of the package is already configureable and the package itself is very specific to the module, we don't need to wrap it in a function call.
There was a problem hiding this comment.
right, but there is currently only one package for upload and remote journal (called systemd-journal-remote) in Debian and RedHat.
This solution gives you the possibility to einer install upload and remote or both.
So I think it's better (and future proof) to keep it like this.
There was a problem hiding this comment.
Oh it's the same package. This packaging is so stupid :(
yes in that case it makes sense to stick to stdlib::ensure_packages()
| } | ||
|
|
||
| service { 'systemd-journal-remote': | ||
| ensure => running, |
There was a problem hiding this comment.
should we also set enable => true, to put it into autostart? usually we do that.
Pull Request (PR) description
add support for uploading journal to a remote server