Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize fcontext parsing methods #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jan 27, 2024

This uses filter_map (introduced in Ruby 2.7) to avoid constructing an array by pushing values. It also uses start_with to avoid a regex lookup.

Untested now, and since there aren't any acceptance tests running now I'm a bit hesitant on merging this.

This uses filter_map (introduced in Ruby 2.7) to avoid constructing an
array by pushing values. It also uses start_with to avoid a regex
lookup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant