selinux_login provider typo & title mismatch #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the title is just the login name we should be using the login name for comparisons. See 340c17e
ekohl
reviewed
Jan 18, 2024
There was a problem hiding this comment.
Is it possible to cover this with tests? I know acceptance is hard, but didn't we have workers for this @bastelfreak?
|
I agree tests for this would be ideal, however I'm a bit out of my depth with puppet provider changes already |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
selinux::loginfails to run due to two bugs in theselinux_loginprovider.Typo
Is presumably a typo in
each_valuesInconsistency in the titles between resources and instances
This logic used to use the title of
#{selinux_login_name}_#{selinux_user}but has been changed to just use theselinux_login_name(340c17e).When we check
resource = resources[provider.name]the inconsistency means if the resource already exists we get the following error.