Use bolt_supported beaker helper #521
Merged
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires - voxpupuli/beaker_puppet_helpers#42. |
traylenator
force-pushed
the
bolt_supported
branch
2 times, most recently
from
f5d8318
to
19432a6
Compare
Use new bolt_supported helper to conditionally setup and run beaker tests. Since bolt is available for RHEL9 at the time of writing this will enable bolt tests for RHEL9.
traylenator
force-pushed
the
bolt_supported
branch
from
19432a6
to
5208433
Compare
bastelfreak
approved these changes
May 2, 2024
ekohl
approved these changes
May 2, 2024
There was a problem hiding this comment.
If I'm really pedantic I'd prefer a release of voxpupuli-acceptance that ensures the presence, so I've opened voxpupuli/voxpupuli-acceptance#79. If we release that as 3.1.0 then we can ensure the helper is present by updating Gemfile here.
|
Somewhat guessing what is meant to be put in modulesync config to overide default version of voxpup-acceptance. |
|
I took the liberty of pushing straight to master and https://github.com/voxpupuli/voxpupuli-acceptance/actions/runs/8921727091 completed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Use new
bolt_supported?helper to conditionally setup and run beaker tests.The
bolt_supported?helper is available with rubygem-beaker_puppet_helpers v1.3.0Since bolt is available for RHEL9 at the time of writing this will
enable bolt tests for RHEL9.