add possibility to force service and spec tests for service #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should give some more flexibility in the future.
trefzer
force-pushed
the
dev_fix_service
branch
from
bfa3316 to
3783fe4
Compare
trefzer
force-pushed
the
dev_fix_service
branch
from
3783fe4 to
3d4dbaf
Compare
bastelfreak
reviewed
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
There are three commits, which all shall not change the current behaviour:
first add spec tests for prosody::service class, secondly simplify the prosody::service class to not have any statements depending on os facts (these should be managed with hiera).
The third one is the important one, currently service cannot be managed without setting prosody::daemonize to true. But with systemd we like to set daemonize to false (since systemd likes to run prosody in foreground) and ensure the service (eg for
reload on new certificate etc.)
This Pull Request (PR) fixes the following issues
allow ensurance of prosody service with systemd.
Additional remark
At least on Debian bullseye (and probably buster) which both use systemd by default, we should set prosody::manage_service to true. I can do an pull request for that if you wish as soon as this one is merged.