Update mongodb_exporter to version 0.11.0 #455
Conversation
Co-authored-by: Tim Meusel <[email protected]>
…ry since version 0.7.0
|
@voxpupuli/collaborators Does anyone know if the failed builds are related to the following error message? I have run the acceptance tests locally, logged into the docker container and the process exists with that parameter. |
|
voxpupuli/beaker-hostgenerator#183 but generally that's not really relevant. |
| pp = "class { 'prometheus::mongodb_exporter': version => '0.11.0', use_kingpin => true }" | ||
| apply_manifest(pp, catch_failures: true) | ||
| apply_manifest(pp, catch_changes: true) | ||
| shell('sleep 30') |
There was a problem hiding this comment.
Could it be this sleep is not working correctly? With systemd I'd suggest some proper ready check. Ideally using the notify type but the exporter probably doesn't support that. An alternative is theforeman/puppet-qpid@7534cd9
There was a problem hiding this comment.
That is an interesting thought.
In the case of puppet-jira, shell('sleep x') is used quite often and this certainly has a negative effect on the runtime of the build jobs.
In this case, however, you should only make sure that the service has been started before checking if the port is open.
There was a problem hiding this comment.
With systemd, a properly written service will not return until it has properly started. Since they often run in the foreground, there is no forking and initialization in the background. The idea of that alternative is that systemd checks the port is open and only then does systemctl start $service return.
| group => 0, # 0 instead of root because OS X uses "wheel". | ||
| mode => '0555', | ||
| } | ||
| -> archive { "/tmp/${service_name}-${version}.${download_extension}": |
There was a problem hiding this comment.
We should not be using the arrow syntax between resources like this and should instead use before/require and notify/subscribe metaparameters.
There was a problem hiding this comment.
Looks like this was no problem two years ago:
- https://github.com/voxpupuli/puppet-prometheus/pull/236/files
- https://github.com/voxpupuli/puppet-archive#puppet-staging-with-zip-file-extraction
Good luck with checking the remaining ~130 modules.
Fixes #350, #366