-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use apt keyring on Debian #189
Conversation
Requires #191 |
Now that #191 is merged, does this need to be rebased before the tests can pass or should we be able to just trigger them again? |
Please rebase, I think there is also some tests you need to adapt. |
@jonhattan Can you rebase? |
Rebased. I don't know how to fix the test. IMO |
Something like is_expected.to contain_apt__source('apt_gitlabci').with_key('name' => 'gitlab_ci_runner.asc', 'source' => 'https://packages.gitlab.com/gpg.key') should do it. |
Please remove the refrence to #188 from the first comment, that is a pull request not an issue |
I think it is ready now |
Pull Request (PR) description
Indirectly use
apt::keyring
instead ofapt::key
(deprecated) by passingname
istead ofid
inapt::source
'skey
subkey.This is almost the same fix as #188 but that other is wrong because the gpg key filename must use
.asc
extension since gitlab provided one is ascii armored.