Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin thor to 1.3.0 #282

Merged
merged 1 commit into from
May 17, 2024
Merged

pin thor to 1.3.0 #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modulesync.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency 'gitlab', '~>4.0'
spec.add_runtime_dependency 'octokit', '>=4', '<9'
spec.add_runtime_dependency 'puppet-blacksmith', '>= 3.0', '< 8'
spec.add_runtime_dependency 'thor'
spec.add_runtime_dependency 'thor', '1.3.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it have pinned to NOT 1.3.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's correct? 1.3.1 has a regression and rails/thor#878 contains a potential fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to pin to != 1.3.1. I shouldn't send comments as I'm changing trains using the mobile app. Never ends well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok. I considered that, but I don't know if the fix will be in 1.3.2 or later. So I think the safer way is pinning to 1.3.0 and dependabot will inform us for new releases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I mention it is because dependabot also informed us about 1.3.1, but yes, this stuff is always annoying

end
Loading