Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for OS core facts #367

Merged
merged 1 commit into from
Jun 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions spec/facts_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,14 @@
expect(content['systemd_version']).to be_nil
expect(content['systemd_internal_services']).to be_nil
end

# those are used in newer rspec-puppet-facts versions
# by ensuring those facts exists, we can drop a huge amount of logic in rspec-puppet-facts
it 'contains the mandatory OS facts' do
expect(content['os']['release']['major']).to not_be_nil.and not_be_empty
expect(content['os']['name']).to not_be_nil.and not_be_empty
expect(content['os']['hardware']).to not_be_nil.and not_be_empty
end
end
end
end