-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Facter 3 and older factsets #298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason I'm in favor of this is faster load times at runtime.
Since we need to update the README as well and do a major version bump, perhaps it's a good time to revisit #262.
My browser was really unhappy trying to open the diff for this PR :-P |
ddd7ab6
to
e71ec2b
Compare
I did a rebase. I'm not sure why some of the tests fail 🤔 someone has an idea? |
When I change |
ah lol, yes. Thanks! |
Puppet 7 is the oldest supported Puppet version. It vendors Facter 4. The facterdb performance depends on the amount of factsets so it makes sense to get rid of the legacy factsets.
IMO this is ready. I ensured that all modern facts are up2date and did a new minor release. I think we can drop the old stuff now. |
I'm ok with dropping facter 3. Puppet 7 was released over 3 years ago, puppet 6 is EOL for over a year |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the actual file changes, but in principle I'm in favor of dropping the old versions. They aren't changing, so if people need to use them, they can pin to an older release.
Puppet 7 is the oldest supported Puppet version. It vendors Facter 4. The facterdb performance depends on the amount of factsets so it makes sense to get rid of the legacy factsets.