Add modal routing optimization #5995
benjaminpkanepr.yml
on: pull_request
Matrix: test / test-python
build
/
changes
26s
build
/
build
3m 51s
lint
/
eslint
2m 53s
test
/
test-app
3m 1s
e2e
/
test-e2e
26m 23s
teams
0s
all-tests
0s
Annotations
13 errors, 20 warnings, and 1 notice
|
[chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders:
e2e-pw/src/oss/poms/modal/index.ts#L251
1) [chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
at oss/poms/modal/index.ts:251
249 |
250 | async waitForSampleLoadDomAttribute(allowErrorInfo = false) {
> 251 | return this.page.waitForFunction(
| ^
252 | (allowErrorInfo) => {
253 | if (
254 | allowErrorInfo &&
at ModalPom.waitForSampleLoadDomAttribute (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/index.ts:251:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:83:17
|
|
[chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders:
e2e-pw/src/oss/poms/modal/index.ts#L251
1) [chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
at oss/poms/modal/index.ts:251
249 |
250 | async waitForSampleLoadDomAttribute(allowErrorInfo = false) {
> 251 | return this.page.waitForFunction(
| ^
252 | (allowErrorInfo) => {
253 | if (
254 | allowErrorInfo &&
at ModalPom.waitForSampleLoadDomAttribute (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/index.ts:251:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:83:17
|
|
[chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders:
e2e-pw/src/oss/fixtures/loader.ts#L166
1) [chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: page.waitForSelector: Test ended.
Call log:
- waiting for locator('[data-cy=spotlight-section-forward]') to be visible
- locator resolved to hidden <div data-cy="spotlight-section-forward" class="_spotlightContainer_f6hfo_19"></div>
at oss/fixtures/loader.ts:166
164 | }
165 |
> 166 | await page.waitForSelector(
| ^
167 | `[data-cy=${withGrid ? "spotlight-section-forward" : "panel-container"}]`,
168 | {
169 | state: "visible",
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:166:16)
|
|
[chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders:
e2e-pw/src/oss/poms/modal/index.ts#L251
1) [chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
at oss/poms/modal/index.ts:251
249 |
250 | async waitForSampleLoadDomAttribute(allowErrorInfo = false) {
> 251 | return this.page.waitForFunction(
| ^
252 | (allowErrorInfo) => {
253 | if (
254 | allowErrorInfo &&
at ModalPom.waitForSampleLoadDomAttribute (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/index.ts:251:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:83:17
|
|
[chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders:
e2e-pw/src/oss/fixtures/loader.ts#L166
1) [chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: page.waitForSelector: Test ended.
Call log:
- waiting for locator('[data-cy=spotlight-section-forward]') to be visible
- locator resolved to hidden <div data-cy="spotlight-section-forward" class="_spotlightContainer_f6hfo_19"></div>
at oss/fixtures/loader.ts:166
164 | }
165 |
> 166 | await page.waitForSelector(
| ^
167 | `[data-cy=${withGrid ? "spotlight-section-forward" : "panel-container"}]`,
168 | {
169 | state: "visible",
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:166:16)
|
|
[chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders:
e2e-pw/src/oss/poms/modal/index.ts#L251
1) [chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders
Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
at oss/poms/modal/index.ts:251
249 |
250 | async waitForSampleLoadDomAttribute(allowErrorInfo = false) {
> 251 | return this.page.waitForFunction(
| ^
252 | (allowErrorInfo) => {
253 | if (
254 | allowErrorInfo &&
at ModalPom.waitForSampleLoadDomAttribute (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/index.ts:251:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:83:17
|
|
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice:
e2e-pw/src/oss/poms/modal/index.ts#L251
2) [chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
at oss/poms/modal/index.ts:251
249 |
250 | async waitForSampleLoadDomAttribute(allowErrorInfo = false) {
> 251 | return this.page.waitForFunction(
| ^
252 | (allowErrorInfo) => {
253 | if (
254 | allowErrorInfo &&
at ModalPom.waitForSampleLoadDomAttribute (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/index.ts:251:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:93:17
|
|
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice:
e2e-pw/src/oss/poms/modal/index.ts#L251
2) [chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
at oss/poms/modal/index.ts:251
249 |
250 | async waitForSampleLoadDomAttribute(allowErrorInfo = false) {
> 251 | return this.page.waitForFunction(
| ^
252 | (allowErrorInfo) => {
253 | if (
254 | allowErrorInfo &&
at ModalPom.waitForSampleLoadDomAttribute (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/index.ts:251:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:93:17
|
|
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice:
e2e-pw/src/oss/poms/modal/index.ts#L251
2) [chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
at oss/poms/modal/index.ts:251
249 |
250 | async waitForSampleLoadDomAttribute(allowErrorInfo = false) {
> 251 | return this.page.waitForFunction(
| ^
252 | (allowErrorInfo) => {
253 | if (
254 | allowErrorInfo &&
at ModalPom.waitForSampleLoadDomAttribute (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/index.ts:251:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:93:17
|
|
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice:
e2e-pw/src/oss/poms/modal/index.ts#L251
2) [chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
at oss/poms/modal/index.ts:251
249 |
250 | async waitForSampleLoadDomAttribute(allowErrorInfo = false) {
> 251 | return this.page.waitForFunction(
| ^
252 | (allowErrorInfo) => {
253 | if (
254 | allowErrorInfo &&
at ModalPom.waitForSampleLoadDomAttribute (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/index.ts:251:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:93:17
|
|
test / test-python (ubuntu-latest-m, 3.9)
Process completed with exit code 2.
|
|
test / test-python (ubuntu-latest-m, 3.9)
Process completed with exit code 123.
|
|
all-tests
Process completed with exit code 1.
|
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L37
React Hook useEffect has missing dependencies: 'panelId' and 'setPanelCloseEffect'. Either include them or remove the dependency array
|
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L101
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
|
|
lint / eslint:
app/packages/operators/src/built-in-operators.ts#L815
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
lint / eslint
'path' is never reassigned. Use 'const' instead
|
|
lint / eslint
'value' is never reassigned. Use 'const' instead
|
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test / test-python (ubuntu-latest-m, 3.11)
Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts took 55.0s
|
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts took 24.9s
|
|
Slow Test:
e2e-pw/[chromium] › oss/specs/selection.spec.ts#L1
e2e-pw/[chromium] › oss/specs/selection.spec.ts took 17.4s
|
|
Slow Test:
e2e-pw/[chromium] › oss/specs/sidebar/sidebar.spec.ts#L1
e2e-pw/[chromium] › oss/specs/sidebar/sidebar.spec.ts took 17.1s
|
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/tagger.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/tagger.spec.ts took 16.5s
|
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
🎭 Playwright Run Summary
2 failed
[chromium] › oss/specs/regression-tests/group-video/default-video-slice-group.spec.ts:77:3 › default video slice group › video as default slice renders
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
12 flaky
[chromium] › oss/specs/grid-tagging.spec.ts:42:1 › grid tagging ────────────────────────────────
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar ───
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar ───
[chromium] › oss/specs/groups/nested-dynamic-groups.spec.ts:116:1 › dynamic groups of groups works
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice ────────────────────
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice ────────────────────
[chromium] › oss/specs/smoke-tests/embeddings.spec.ts:62:3 › embeddings on quickstart dataset › lasso samples work
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:79:5 › quickstart-groups › modal › navigation works
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:104:5 › quickstart-groups › modal › group media visibility toggle works
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:139:3 › quickstart-groups › modal with grid filter
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:63:3 › quickstart › entry counts text when toPatches then groupedBy
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:80:3 › quickstart › selection bookmark ───
2 skipped
91 passed (20.5m)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
dist
|
19.7 MB |
|
|
playwright-report
|
72.4 MB |
|