wip: improve modal perf #5974
Triggered via pull request
October 30, 2024 12:31
Status
Failure
Total duration
1h 20m 56s
Artifacts
2
pr.yml
on: pull_request
Matrix: test / test-python
build
/
changes
26s
build
/
build
2m 29s
lint
/
eslint
1m 3s
test
/
test-app
1m 25s
e2e
/
test-e2e
1h 6m
teams
0s
all-tests
0s
Annotations
10 errors, 19 warnings, and 1 notice
[chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode:
e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts#L1
1) [chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode, use tag as colorByAttribute
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode:
e2e-pw/src/shared/event-utils/index.ts#L16
1) [chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode, use tag as colorByAttribute
Error: page.evaluate: Test timeout of 60000ms exceeded.
at shared/event-utils/index.ts:16
14 |
15 | // note: cannot directly pass function to `evaluate`, which is why we expose it to the `window` object first
> 16 | return this.page.evaluate(
| ^
17 | ({ eventName_, exposedFunctionName_ }) =>
18 | new Promise<void>((resolve) => {
19 | const cb = (e: CustomEvent) => {
at EventUtils.getEventReceivedPromiseForPredicate (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/shared/event-utils/index.ts:16:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts:74:18
|
[chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode:
e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts#L1
1) [chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode, use tag as colorByAttribute
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode:
e2e-pw/src/shared/event-utils/index.ts#L16
1) [chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode, use tag as colorByAttribute
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: page.evaluate: Test timeout of 60000ms exceeded.
at shared/event-utils/index.ts:16
14 |
15 | // note: cannot directly pass function to `evaluate`, which is why we expose it to the `window` object first
> 16 | return this.page.evaluate(
| ^
17 | ({ eventName_, exposedFunctionName_ }) =>
18 | new Promise<void>((resolve) => {
19 | const cb = (e: CustomEvent) => {
at EventUtils.getEventReceivedPromiseForPredicate (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/shared/event-utils/index.ts:16:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts:74:18
|
[chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode:
e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts#L1
1) [chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode, use tag as colorByAttribute
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode:
e2e-pw/src/shared/event-utils/index.ts#L16
1) [chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode, use tag as colorByAttribute
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: page.evaluate: Test timeout of 60000ms exceeded.
at shared/event-utils/index.ts:16
14 |
15 | // note: cannot directly pass function to `evaluate`, which is why we expose it to the `window` object first
> 16 | return this.page.evaluate(
| ^
17 | ({ eventName_, exposedFunctionName_ }) =>
18 | new Promise<void>((resolve) => {
19 | const cb = (e: CustomEvent) => {
at EventUtils.getEventReceivedPromiseForPredicate (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/shared/event-utils/index.ts:16:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts:74:18
|
[chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode:
e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts#L1
1) [chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode, use tag as colorByAttribute
Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode:
e2e-pw/src/shared/event-utils/index.ts#L16
1) [chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode, use tag as colorByAttribute
Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
Error: page.evaluate: Test timeout of 60000ms exceeded.
at shared/event-utils/index.ts:16
14 |
15 | // note: cannot directly pass function to `evaluate`, which is why we expose it to the `window` object first
> 16 | return this.page.evaluate(
| ^
17 | ({ eventName_, exposedFunctionName_ }) =>
18 | new Promise<void>((resolve) => {
19 | const cb = (e: CustomEvent) => {
at EventUtils.getEventReceivedPromiseForPredicate (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/shared/event-utils/index.ts:16:22)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts:74:18
|
[chromium] › oss/specs/grid-tagging.spec.ts:42:1 › grid tagging:
e2e-pw/src/oss/specs/grid-tagging.spec.ts#L1
2) [chromium] › oss/specs/grid-tagging.spec.ts:42:1 › grid tagging ───────────────────────────────
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/grid-tagging.spec.ts:42:1 › grid tagging:
e2e-pw/src/oss/poms/grid/index.ts#L70
2) [chromium] › oss/specs/grid-tagging.spec.ts:42:1 › grid tagging ───────────────────────────────
Error: locator.scrollIntoViewIfNeeded: Test timeout of 60000ms exceeded.
Call log:
- attempting scroll into view action
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #1
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #2
- waiting 20ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #3
- waiting 100ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #4
- waiting 100ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #5
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #6
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #7
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #8
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #9
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #10
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #11
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #12
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #13
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #14
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #15
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #16
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #17
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #18
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #19
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #20
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #21
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #22
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #23
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #24
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #25
- waiting 500ms
- waiting for element to be stable
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L40
React Hook useEffect has missing dependencies: 'panelId', 'panelName', 'setPanelCloseEffect', and 'trackEvent'. Either include them or remove the dependency array
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L104
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
|
lint / eslint:
app/packages/operators/src/built-in-operators.ts#L815
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'path' is never reassigned. Use 'const' instead
|
lint / eslint
'value' is never reassigned. Use 'const' instead
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.11)
Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts took 56.6s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts took 50.2s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/operators/prompt.spec.ts#L1
e2e-pw/[chromium] › oss/specs/operators/prompt.spec.ts took 15.8s
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
🎭 Playwright Run Summary
24 failed
[chromium] › oss/specs/color-scheme/color-scheme.spec.ts:63:3 › color scheme basic functionality with quickstart › update color by value mode, use tag as colorByAttribute
[chromium] › oss/specs/grid-tagging.spec.ts:42:1 › grid tagging ────────────────────────────────
[chromium] › oss/specs/groups/ima-vid.spec.ts:118:1 › check modal playback and tagging behavior
[chromium] › oss/specs/groups/nested-dynamic-groups.spec.ts:116:1 › dynamic groups of groups works
[chromium] › oss/specs/groups/sparse-groups-scenes.spec.ts:56:1 › ego default group slice transitions
[chromium] › oss/specs/modal/linking.spec.ts:41:1 › sample linking ─────────────────────────────
[chromium] › oss/specs/modal/linking.spec.ts:52:1 › group linking ──────────────────────────────
[chromium] › oss/specs/operators/panels-modal.spec.ts:41:1 › Modal Panels: Counter ─────────────
[chromium] › oss/specs/plugins/histograms.spec.ts:46:1 › histograms panel ──────────────────────
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ───────────────────
[chromium] › oss/specs/regression-tests/sidebar/sidebar-datetime.spec.ts:72:3 › date field and date time field can filter visibility › change date field visibility works
[chromium] › oss/specs/regression-tests/sidebar/sidebar-datetime.spec.ts:92:3 › date field and date time field can filter visibility › change datetime field visibility works
[chromium] › oss/specs/selection.spec.ts:47:3 › mp4 grid selection ─────────────────────────────
[chromium] › oss/specs/selection.spec.ts:47:3 › pcd grid selection ─────────────────────────────
[chromium] › oss/specs/selection.spec.ts:47:3 › png grid selection ─────────────────────────────
[chromium] › oss/specs/sidebar/sidebar-cifar.spec.ts:29:3 › classification-sidebar-filter-visibility › In cifar grid, setting visibility directly works
[chromium] › oss/specs/sidebar/sidebar-cifar.spec.ts:74:3 › classification-sidebar-filter-visibility › In cifar grid, show samples with a label filter works
[chromium] › oss/specs/sidebar/sidebar-cifar.spec.ts:141:3 › classification-sidebar-filter-visibility › In cifar grid, omit samples with a label filter works
[chromium] › oss/specs/sidebar/sidebar.spec.ts:87:3 › sidebar-filter-visibility › In grid, exclude a label filter works
[chromium] › oss/specs/sidebar/sidebar.spec.ts:203:3 › sidebar-filter-visibility › In grid, omit samples with a label filter works
[chromium] › oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:61:3 › quickstart-groups › dynamic groups
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:71:5 › quickstart-groups › modal › changes slice to "pcd" when 3D viewer is clicked
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:36:3 › quickstart › smoke ────────────────
4 flaky
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice ────────────────────
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice ────────────────────
[chromium] › oss/specs/smoke-tests/embeddings.spec.ts:62:3 › embeddings on quickstart dataset › lasso samples work
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:80:3 › quickstart › selection bookmark ───
2 skipped
75 passed (59.3m)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
dist
|
19.8 MB |
|
playwright-report
|
613 MB |
|