Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squeezelite 2.0.0 for Volumio 3. #222

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LarsGrootkarzijn
Copy link
Contributor

@LarsGrootkarzijn LarsGrootkarzijn commented May 29, 2023

As I recently fixed LMS, but there was no current stable Squeezelite plugin I decided to fix Sayato his Squeezelite plugin. I saw he earlier tried a pull request as well. Back then the following points were made which made the pull request unaccaptable:

  1. Squeezelite not installing at all -> fixed

  2. Did not use the Volumio 3 standard.

I fixed this by removing the ability of selecting an output device, and now just use the volumio output device. One thing I am not sure about is if these settings can stay or have to be removed as well:

image

  1. The config file was not getting written -> fixed.

  2. Potential fatal error when writing to config.json -> fixed.

Plugin is not yet submitted, but I made a request to @volumio via mail as I am not the original owner.

@LarsGrootkarzijn
Copy link
Contributor Author

Should now be submitted aswell :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant