Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and simplify play ht synthesizer config #348

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

divst3r
Copy link
Contributor

@divst3r divst3r commented Aug 7, 2023

Add tests for play ht synthesizer and simplify it's config in vocode python

@divst3r divst3r requested a review from ajar98 August 7, 2023 19:37
Copy link
Contributor

@ajar98 ajar98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the test! let's keep around those extra params (seed, temperature, ...) but the api_key and user_id are good!

Copy link
Contributor

@ajar98 ajar98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@ajar98 ajar98 merged commit 8f9f02f into main Aug 9, 2023
4 checks passed
m5a0r7 pushed a commit to m5a0r7/vocode-python that referenced this pull request Oct 19, 2023
* Add test and simplify play ht synthesizer config

* Adding additional parameters back to play ht synthesizer and play ht synthesizer config

* Remove extra /n

---------

Co-authored-by: Divi kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants