Update the play ht synthesizer in vocode-python #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajar98
requested changes
Aug 5, 2023
| @@ -88,12 +92,13 @@ async def main(): | |||
| print("Message sent: ", message_sent) | |||
| except KeyboardInterrupt: | |||
| print("Interrupted, exiting") | |||
| await synthesizer.tear_down() | |||
There was a problem hiding this comment.
remove changes from this file (already in main)
| quality: Optional[str] = PLAYHT_DEFAULT_QUALITY | ||
| output_format: Optional[str] = PLAYHT_DEFAULT_OUTPUT_FORMAT | ||
| speed: Optional[int] = PLAYHT_DEFAULT_SPEED | ||
| sampling_rate: int = PLAYHT_DEFAULT_RATE |
There was a problem hiding this comment.
can't override sampling_rate - this comes from the super class SynthesizerConfig
| preset: Optional[str] = None | ||
| quality: Optional[str] = None | ||
| quality: Optional[str] = PLAYHT_DEFAULT_QUALITY | ||
| output_format: Optional[str] = PLAYHT_DEFAULT_OUTPUT_FORMAT |
There was a problem hiding this comment.
do we have support for other output formats in the synthesizer? it always needs to output wav in the end (that's why we have that AudioSegment.from_mp3 call
| ): | ||
| print(api_key, user_id) |
ajar98
requested changes
Aug 5, 2023
| speed: Optional[str] = None | ||
| preset: Optional[str] = None | ||
| quality: Optional[str] = None | ||
| quality: Optional[str] = PLAYHT_DEFAULT_QUALITY |
There was a problem hiding this comment.
let's keep these as nones (use the Play.ht defaults)
| io.BytesIO(read_response) # type: ignore | ||
| # Run the conversion from MP3 in a separate thread | ||
| loop = asyncio.get_event_loop() | ||
| output_bytes_io = await loop.run_in_executor( |
There was a problem hiding this comment.
doesn't need to be in a thread anymore!
m5a0r7
pushed a commit
to m5a0r7/vocode-python
that referenced
this pull request
Oct 19, 2023
* Updated the play ht synthesizer implementation on vocode-python * fix some imports * fix mypy type error * resolve comment and organize imports * minor fixes * remove quality parameter form play ht synthesizer * resolve comments --------- Co-authored-by: Divi kumar <[email protected]> Co-authored-by: Ajay Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.