Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: circuit unit tests #8

Merged
merged 8 commits into from
Jan 2, 2025
Merged

feature: circuit unit tests #8

merged 8 commits into from
Jan 2, 2025

Conversation

lucasmenendez
Copy link
Contributor

@lucasmenendez lucasmenendez commented Dec 30, 2024 •
edited
Loading

  • End2end circuit tests and helper test moved to new `circuits/test' package (in individual packages per circuit to avoid import cycles).
  • VoteVerifier and Aggregator circuits modified to isolate some logic in new and testable methods.
  • New circuits unit tests.

@lucasmenendez lucasmenendez added the enhancement New feature or request label Dec 30, 2024
@lucasmenendez lucasmenendez requested a review from p4u December 30, 2024 14:07
@lucasmenendez lucasmenendez self-assigned this Dec 30, 2024
@lucasmenendez lucasmenendez marked this pull request as ready for review December 31, 2024 11:46
p4u
p4u approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@p4u p4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Great job Lucas. Just minor comments.

circuits/aggregator/aggregator.go Outdated Show resolved Hide resolved
circuits/aggregator/aggregator_test.go Outdated Show resolved Hide resolved
circuits/voteverifier/vote_verifier.go Outdated Show resolved Hide resolved
@lucasmenendez lucasmenendez merged commit a529ac2 into main Jan 2, 2025
2 checks passed
@lucasmenendez lucasmenendez deleted the f/circuit_unit_tests branch January 2, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p4u p4u p4u approved these changes

Assignees

@lucasmenendez lucasmenendez

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasmenendez @p4u