Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/api blocklist #1369

Merged
merged 2 commits into from
Aug 23, 2024
Merged

feat/api blocklist #1369

merged 2 commits into from
Aug 23, 2024

Conversation

altergui
Copy link
Contributor

  • api: new endpoint /chain/blocks
  • api: endpoint /chain/blocks fetches from a.vocapp.GetBlockByHeight

@altergui
api: new endpoint /chain/blocks
5bde6d9 
accepts QueryParams:
     * GET /chain/blocks
       * page
       * limit
       * chainId
       * hash
       * proposerAddress

* api: add structs BlockList, BlockParams
* api: add consts ParamChainId, ParamHash, ParamProposerAddress
* indexer: add indexertypes.Block
@altergui
api: endpoint /chain/blocks fetches from a.vocapp.GetBlockByHeight
50c3f98
@altergui altergui force-pushed the feat/api-blocklist branch from 4201275 to 50c3f98 Compare August 23, 2024 06:58
@altergui altergui requested a review from elboletaire August 23, 2024 07:03
@coveralls
Copy link

coveralls commented Aug 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10521341829

Details

  • 6 of 79 (7.59%) changed or added relevant lines in 1 file are covered.
  • 27 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 62.256%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/chain.go 6 79 7.59%
Files with Coverage Reduction New Missed Lines %
api/chain.go 27 40.65%
Totals Coverage Status
Change from base Build 10506130491: -0.1%
Covered Lines: 16524
Relevant Lines: 26542
💛 - Coveralls

@altergui altergui linked an issue Aug 23, 2024 that may be closed by this pull request
Implement block list endpoint vocdoni/interoperability#220
Closed
4 tasks
@altergui altergui mentioned this pull request Aug 23, 2024
Closed
4 tasks
@altergui altergui merged commit 50c3f98 into main Aug 23, 2024
26 checks passed
@altergui altergui deleted the feat/api-blocklist branch August 23, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elboletaire elboletaire elboletaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement block list endpoint
3 participants
@altergui @coveralls @elboletaire