Store and retrieve files (for now images) to an s3 like object storage #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmdim
force-pushed
the
f/upload_service
branch
3 times, most recently
from
fc14344 to
bcc7973
Compare
emmdim
force-pushed
the
f/upload_service
branch
from
bcc7973 to
166dbaa
Compare
| } | ||
|
|
||
| // Put uploads a file to the object storage service. | ||
| func (osc *ObjectStorageClient) Put( |
There was a problem hiding this comment.
Few suggestions:
- The comment is quite short for this method, I miss some information about the inputs and their types.
- I suggest that the object can be included into a struct to wrap the
key,type,sizeandmetadata. It can also include the content when it is returned, for example asGetmethod result. - If
contentDispositionhas some possible values, they can be public constans or even create multiplePutmethods:PutInline, ...
|
Replaced by #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoints
Currently one private endpoints will be enabled:
/uploadThe download endpoint is for now ommited since the images will be retrieved directly from the storage hosting service cdn
Key, naming and buckets
There will be a separate route regarding org metadata images and another one for election metadata images
organization/${sha(imageData)}.{png | jpg | jpeg}election/${sha(imageData)}{png | jpg | jpeg}Notes: