F/gasless non wrapped tokens bis

.env.development

@@ -18,7 +18,7 @@ VITE_FEATURE_FLAG_OSX_UPDATES=true
 VITE_FEATURE_FLAG_CONNECT_ANY_DAPP=true
 
 # Enable gasless plugin on DAO creation
-VITE_FEATURE_FLAG_GASLESS_PLUGIN=false
+VITE_FEATURE_FLAG_GASLESS_PLUGIN=true
 
 VITE_VOCDONI_ENV='stg'
 

.env.staging

@@ -18,7 +18,7 @@ VITE_FEATURE_FLAG_OSX_UPDATES=true
 VITE_FEATURE_FLAG_CONNECT_ANY_DAPP=true
 
 # Enable gasless plugin on DAO creation
-VITE_FEATURE_FLAG_GASLESS_PLUGIN=false
+VITE_FEATURE_FLAG_GASLESS_PLUGIN=true
 
 VITE_VOCDONI_ENV='stg'
 

.github/workflows/ai-pr-reviewer.yml

@@ -0,0 +1,31 @@
+name: Code Review
+
+permissions:
+  contents: read
+  pull-requests: write
+
+on:
+  pull_request:
+  pull_request_review_comment:
+    types: [created]
+
+concurrency:
+  group:
+    ${{ github.repository }}-${{ github.event.number || github.head_ref ||
+    github.sha }}-${{ github.workflow }}-${{ github.event_name ==
+    'pull_request_review_comment' && 'pr_comment' || 'pr' }}
+  cancel-in-progress: ${{ github.event_name != 'pull_request_review_comment' }}
+
+jobs:
+  review:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: coderabbitai/ai-pr-reviewer@latest
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
+        with:
+          debug: false
+          review_simple_changes: true
+          review_comment_lgtm: true
+          openai_heavy_model: gpt-4

package.json

@@ -36,10 +36,9 @@
     "@tiptap/pm": "^2.0.3",
     "@tiptap/react": "^2.0.3",
     "@tiptap/starter-kit": "^2.0.3",
-    "@vocdoni/gasless-voting": "0.0.1-rc2",
-    "@vocdoni/gasless-voting-ethers": "0.0.1-rc1",
-    "@vocdoni/react-providers": "0.1.14",
-    "@vocdoni/sdk": "0.5.0",
+    "@vocdoni/gasless-voting": "0.0.1-rc21",
+    "@vocdoni/react-providers": "0.3.1",
+    "@vocdoni/sdk": "0.7.1",
     "@walletconnect/core": "^2.8.3",
     "@walletconnect/utils": "^2.8.3",
     "@walletconnect/web3wallet": "^1.8.2",
@@ -117,7 +116,6 @@
     "vite-tsconfig-paths": "^4.2.0"
   },
   "resolutions": {
-    "@vocdoni/sdk": "0.5.0",
     "@types/react": "^18.2.23"
   },
   "engines": {

src/components/executionExpirationTime/index.tsx

@@ -43,7 +43,11 @@ const ExecutionExpirationTime: React.FC = () => {
         );
         setValue('executionExpirationHours', '0');
         setValue('executionExpirationMinutes', '0');
-      } else if (value === 0 && executionExpirationHours === '0') {
+      } else if (
+        value === 0 &&
+        (executionExpirationHours === undefined ||
+          executionExpirationHours === '0')
+      ) {
         setValue(
           'executionExpirationHours',
           COMMITTEE_EXECUTION_MIN_DURATION_HOURS.toString()

src/components/executionMultisigMinimumApproval/index.tsx

@@ -0,0 +1,87 @@
+import {
+  Controller,
+  useFormContext,
+  useWatch,
+  ValidateResult,
+} from 'react-hook-form';
+import MinimumApproval from '../multisigMinimumApproval/minimumApproval';
+import React, {useCallback, useEffect} from 'react';
+import {generateAlert} from '../multisigMinimumApproval';
+import {useTranslation} from 'react-i18next';
+
+const MIN_REQUIRED_APPROVALS = 1;
+
+export const ExecutionMultisigMinimumApproval = () => {
+  const {t} = useTranslation();
+  const {control, setValue, trigger} = useFormContext();
+  const [committee, committeeMinimumApproval] = useWatch({
+    name: ['committee', 'committeeMinimumApproval'],
+  });
+
+  const committeeCount = committee?.length ?? 0;
+
+  const validateMinimumApproval = (value: number): ValidateResult => {
+    if (value > committeeCount) {
+      return t('errors.minimumApproval.exceedMaxThreshold');
+    } else if (value <= 0) {
+      return t('errors.required.minApproval');
+    }
+    return true;
+  };
+
+  const minApprovalChanged = useCallback(
+    (
+      e: React.ChangeEvent<HTMLInputElement>,
+      onChange: React.ChangeEventHandler
+    ) => {
+      const value = Number(e.target.value);
+      if (value > committeeCount) {
+        setValue('committeeMinimumApproval', committeeCount.toString());
+        e.target.value = committeeCount;
+      }
+      trigger(['committeeMinimumApproval']);
+      onChange(e);
+    },
+    [committeeCount, setValue, trigger]
+  );
+
+  // This is used to update the committeeMinimumApproval when a wallet is deleted
+  useEffect(() => {
+    if (Number(committeeMinimumApproval) === 0 && committeeCount === 1) {
+      setValue('committeeMinimumApproval', committeeCount.toString());
+    } else if (Number(committeeMinimumApproval) > committeeCount) {
+      setValue('committeeMinimumApproval', committeeCount.toString());
+    }
+  }, [committeeCount, committeeMinimumApproval, setValue]);
+
+  return (
+    <>
+      <Controller
+        name="committeeMinimumApproval"
+        control={control}
+        defaultValue="1"
+        rules={{
+          validate: value => validateMinimumApproval(value),
+        }}
+        render={({
+          field: {onBlur, onChange, value, name},
+          fieldState: {error},
+        }) => (
+          <>
+            <MinimumApproval
+              name={name}
+              value={value}
+              min={MIN_REQUIRED_APPROVALS}
+              max={committeeCount}
+              onBlur={onBlur}
+              onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
+                minApprovalChanged(e, onChange)
+              }
+              error={generateAlert(value, committee.length, t, error)}
+            />
+          </>
+        )}
+      />
+    </>
+  );
+};

src/components/executionWidget/actions/modifyGaslessSettingsCard.tsx

@@ -0,0 +1,99 @@
+import React, {useMemo} from 'react';
+import {useTranslation} from 'react-i18next';
+
+import {AccordionMethod} from 'components/accordionMethod';
+import {ActionCardDlContainer, Dd, Dl, Dt} from 'components/descriptionList';
+import {ActionUpdateGaslessSettings} from 'utils/types';
+import {getDHMFromSeconds} from '../../../utils/date';
+import {getErc20MinParticipation} from '../../../utils/proposals';
+import {formatUnits} from 'ethers/lib/utils';
+
+export const ModifyGaslessSettingsCard: React.FC<{
+  action: ActionUpdateGaslessSettings;
+}> = ({action: {inputs}}) => {
+  const {t} = useTranslation();
+  const {days, hours, minutes} = getDHMFromSeconds(inputs.minDuration);
+  const {
+    days: tallyDays,
+    hours: tallyHours,
+    minutes: tallyMinutes,
+  } = getDHMFromSeconds(inputs.minTallyDuration);
+
+  const minParticipation = useMemo(
+    () => `≥ ${Math.round(inputs.minParticipation * 100)}% (≥
+            ${getErc20MinParticipation(
+              inputs.minParticipation,
+              inputs.totalVotingWeight,
+              inputs.token?.decimals || 18
+            )}
+            ${inputs.token?.symbol})`,
+    [
+      inputs.minParticipation,
+      inputs.token?.decimals,
+      inputs.token?.symbol,
+      inputs.totalVotingWeight,
+    ]
+  );
+
+  const minProposalThreshold = inputs.minProposerVotingPower
+    ? t('labels.review.tokenHoldersWithTkns', {
+        tokenAmount: formatUnits(
+          inputs.minProposerVotingPower,
+          inputs.token?.decimals
+        ),
+        tokenSymbol: inputs.token?.symbol,
+      })
+    : t('createDAO.step3.eligibility.anyWallet.title');
+
+  return (
+    <AccordionMethod
+      type="execution-widget"
+      methodName={t('labels.updateExecutionMultisigAction')}
+      smartContractName={t('labels.aragonOSx')}
+      methodDescription={t('labels.updateExecutionMultisigActionDescription')}
+      verified
+    >
+      <ActionCardDlContainer>
+        <Dl>
+          <Dt>{t('labels.minimumParticipation')}</Dt>
+          <Dd>{minParticipation}</Dd>
+        </Dl>
+        <Dl>
+          <Dt>{t('labels.review.proposalThreshold')}</Dt>
+          <Dd>{minProposalThreshold}</Dd>
+        </Dl>
+        <Dl>
+          <Dt>{t('labels.minimumDuration')}</Dt>
+          <Dd>
+            <div className="space-x-3">
+              <span>{t('createDAO.review.days', {days})}</span>
+              <span>{t('createDAO.review.hours', {hours})}</span>
+              <span>{t('createDAO.review.minutes', {minutes})}</span>
+            </div>
+          </Dd>
+        </Dl>
+        <Dl>
+          <Dt>{t('labels.minimumApproval')}</Dt>
+          <Dd>
+            {inputs.minTallyApprovals}&nbsp;
+            {t('labels.review.multisigMinimumApprovals', {
+              count: inputs.executionMultisigMembers?.length || 0,
+            })}
+          </Dd>
+        </Dl>
+        <Dl>
+          <Dt>{t('createDao.executionMultisig.executionTitle')}</Dt>
+          <Dd>
+            <div className="space-x-3">
+              <span>{t('createDAO.review.days', {days: tallyDays})}</span>
+              <span>{t('createDAO.review.hours', {hours: tallyHours})}</span>
+              <span>
+                {t('createDAO.review.minutes', {minutes: tallyMinutes})}
+              </span>
+            </div>
+          </Dd>
+        </Dl>
+      </ActionCardDlContainer>
+    </AccordionMethod>
+  );
+};

src/components/executionWidget/actionsFilter.tsx

@@ -12,6 +12,7 @@ import {SCCExecutionCard} from './actions/sccExecutionWidget';
 import {WCActionCard} from './actions/walletConnectActionCard';
 import {WithdrawCard} from './actions/withdrawCard';
 import {toDisplayEns} from 'utils/library';
+import {ModifyGaslessSettingsCard} from './actions/modifyGaslessSettingsCard';
 
 type ActionsFilterProps = {
   action: Action;
@@ -52,6 +53,8 @@ export const ActionsFilter: React.FC<ActionsFilterProps> = ({
       return (
         <WCActionCard action={action} type="execution-widget" status={status} />
       );
+    case 'modify_gasless_voting_settings':
+      return <ModifyGaslessSettingsCard action={action} />;
     case 'plugin_update':
     default:
       return <></>;

src/components/membersList/index.tsx

@@ -12,6 +12,8 @@ import styled from 'styled-components';
 import {useScreen} from '@aragon/ods-old';
 import {useTranslation} from 'react-i18next';
 import {featureFlags} from 'utils/featureFlags';
+import {useGaslessGovernanceEnabled} from '../../hooks/useGaslessGovernanceEnabled';
+import {useDaoDetailsQuery} from '../../hooks/useDaoDetails';
 
 type MembersListProps = {
   members: DaoMember[];
@@ -32,6 +34,11 @@ export const MembersList: React.FC<MembersListProps> = ({
   const {isDesktop} = useScreen();
   const {t} = useTranslation();
 
+  // Gasless voting plugin support non wrapped tokens
+  // Used to hide delegation column in case of gasless voting plugin
+  const {data: daoDetails} = useDaoDetailsQuery();
+  const {isGovernanceEnabled} = useGaslessGovernanceEnabled(daoDetails);
+
   const isTokenBasedDao = token != null;
   const useCompactMode = isCompactMode ?? !isDesktop;
   const enableDelegation =
@@ -94,7 +101,7 @@ export const MembersList: React.FC<MembersListProps> = ({
                   {t('community.listHeader.votingPower')}
                 </TableCellHead>
               )}
-              {showDelegationHeaders && (
+              {showDelegationHeaders && isGovernanceEnabled && (
                 <TableCellHead>
                   {t('community.listHeader.delegations')}
                 </TableCellHead>

src/components/proposalList/index.tsx

@@ -211,10 +211,10 @@ export function proposal2CardProps(
       alertMessage: translateProposalDate(
         proposal.status,
         proposal.startDate,
-        proposal.endDate
+        proposal.tallyEndDate
       ),
-      title: proposal.vochain.metadata.title.default,
-      description: proposal.vochain.metadata.questions[0].title.default,
+      title: proposal.metadata.title,
+      description: proposal.metadata.description,
     };
     return {...props, ...specificProps};
   } else if (isErc20VotingProposal(proposal)) {

src/components/verificationCard/index.tsx

@@ -23,13 +23,15 @@ const VerificationCard: React.FC<TransferListProps> = ({tokenAddress}) => {
     tokenTotalSupply,
     tokenTotalHolders,
     tokenType,
+    votingType,
   ] = useWatch({
     name: [
       'tokenName',
       'tokenSymbol',
       'tokenTotalSupply',
       'tokenTotalHolders',
       'tokenType',
+      'votingType',
     ],
     control: control,
   });
@@ -52,6 +54,19 @@ const VerificationCard: React.FC<TransferListProps> = ({tokenAddress}) => {
   const Alert = useMemo(() => {
     switch (tokenType) {
       case 'ERC-20':
+        if (votingType === 'gasless') {
+          return (
+            <AlertCard
+              mode="success"
+              title={t(
+                'createDAO.step3.existingToken.verificationAlertSuccessTitle'
+              )}
+              helpText={
+                'DEV The ERC20 token selected is compatible for voting on the Vocdoni system'
+              }
+            />
+          );
+        }
         return (
           <AlertCard
             mode="warning"
@@ -107,7 +122,7 @@ const VerificationCard: React.FC<TransferListProps> = ({tokenAddress}) => {
       default:
         return null;
     }
-  }, [t, tokenSymbol, tokenType]);
+  }, [t, tokenSymbol, tokenType, votingType]);
 
   const formattedTokenTotalSupply = useMemo(() => {
     if (tokenTotalSupply < 100) {