Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Mutation policy documentation #286

Merged
2 commits merged into from Oct 17, 2023
Merged

[Feature] Mutation policy documentation #286

2 commits merged into from Oct 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2023

  1. What this PR does / why we need it:

  2. Which issue(s) this PR fixes

     (optional, in `fixes #<issue number>` format, will close the issue(s) when PR gets merged):
    
     Fixes #
    
  3. Additional information
    Related task:
    TMC-35638

  4. Special notes for your reviewer

@ghost ghost requested a review from vrabbi October 6, 2023 14:16
Copy link
Contributor

@ramya-bangera ramya-bangera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekoop-terasky - Please include the schema like this

@ghost
Copy link
Author

ghost commented Oct 15, 2023

@ekoop-terasky - Please include the schema like this

I introduced following change in this PR too.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ea40271) 25.58% compared to head (8e14d1c) 25.68%.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/mutation_policy     #286      +/-   ##
===========================================================
+ Coverage                    25.58%   25.68%   +0.09%     
===========================================================
  Files                          161      160       -1     
  Lines                        14351    14222     -129     
===========================================================
- Hits                          3672     3653      -19     
+ Misses                       10511    10401     -110     
  Partials                       168      168              

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost requested a review from ramya-bangera October 15, 2023 13:43
Copy link
Member

@aqstack aqstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Erki Koop added 2 commits October 17, 2023 10:06
Signed-off-by: Erki Koop <[email protected]>
Copy link

@vrabbi vrabbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit df02b1c into vmware:feature/mutation_policy Oct 17, 2023
2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants