🌱 Consistently use the default config for controller integration tests #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the feature state for the ConfigMap capabilities controller. It is only used when SVAsyncUpgrade is false but the setup was setting it to true. The fallout from this is that the WorkloadDomainIsolation feature is not via the capability when async upgrade is false so remove that from the integration tests.
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Also fix the feature state for the ConfigMap capabilities controller. It is only used when SVAsyncUpgrade is false but the setup was setting it to true. The fallout from this is that the WorkloadDomainIsolation feature is not via the capability when async upgrade is false so remove that from the integration tests.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
The CM capability controller is mostly moot at this point, and it may be time to update the Default().
Please add a release note if necessary: