🌱 Enable all errorlint checks #839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruneshpa
approved these changes
Dec 24, 2024
| @@ -66,7 +67,8 @@ func GetStorageClassesForPolicy( | |||
| namespace, | |||
| o.Name) | |||
| if err != nil { | |||
| if _, ok := err.(NotFoundInNamespace); !ok { | |||
| var notFoundInNamespace NotFoundInNamespace | |||
| if !errors.As(err, ¬FoundInNamespace) { | |||
There was a problem hiding this comment.
Out of curiosity, can we not use https://pkg.go.dev/errors#Is here?
And another place, you have used fault.As for a similar check.
| @@ -102,6 +103,8 @@ func ContainsError(err error, message string) bool { | |||
| return true | |||
| } | |||
| } | |||
| default: | |||
There was a problem hiding this comment.
Out of curiosity, why did you have to add the nolint and why this default block?
Use %w instead of %v to wrap errors Use errors Is() and As() and the govmomi fault equivalents instead of type casting/checking
bryanv
force-pushed
the
bryanv/enable-errorlint-checks
branch
from
74c81d7 to
d492353
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Use %w instead of %v to wrap errors
Use errors Is() and As() and the govmomi equivalents instead of type casting/checking
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: