-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Ignore IPv6 Route advertisement in case DHCPv6 wasn't requested #788
Open
rikatz
wants to merge
1
commit into
vmware-tanzu:main
Choose a base branch
from
rikatz:pass-accept-ra-to-cloudinit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
On some networks IPv6 is announced via RA. Networkd (and maybe netplan) separates DHCPv6 and RA enablement, meaning that even when users set to ignore/disable DHCPv6, IPv6 is still configured on the Host VM if there is some Route Advertisement for IPv6.
Turns out on some setups this may break the desired behavior, as DNSv6 and others may also end up being configured on the node using IPv6.
This PR sets the accept-ra value to the same value as DHCPv6, so in case user didn't explicitly requested IPv6 dynamic configuration, DHCPv6 nor Route Advertisements will be used.
This fix needs cloud-init 24.2 on Photon5 to work correctly.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: