✨ Unifiy build process up and downstream #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the upstream image-build target and Dockerfile
to no longer do a staged build, building VM Op inside of the
container. Instead, the binaries are now built prior to building
the container.
This, as well as a few other changes to the version variables in
the Makefile, allow the up and downstream build processes for VM
Op to be unified. Now the internal process can invoke the following
to build VM Op from the upstream Makefile:
ADDITIONAL_CRI_BUILD_FLAGS="--network=host" \
BASE_IMAGE="<INTERNAL_CONTAINER_IMAGE>" \
BUILD_BRANCH="$(BUILD_BRANCH)" \
BUILD_COMMIT="$(BUILD_COMMIT)" \
BUILD_NUMBER="$(BUILD_NUMBER)" \
BUILD_VERSION="$(BUILD_VERSION)" \
IMAGE="$(IMAGE)" \
IMAGE_TAG="$(IMAGE_TAG)" \
IMAGE_VERSION="$(IMAGE_VERSION)" \
PRDCT_VERSION="$(PRDCT_VERSION)" \
make image-build-amd64
This patch also removes the GitHub jobs for building the manager
and web console validator binaries as both are built as part of
the "build-image" job.
Minimum allowed line rate is |
sreyasn
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch changes the upstream image-build target and Dockerfile to no longer do a staged build, building VM Op inside of the container. Instead, the binaries are now built prior to building the container.
This, as well as a few other changes to the version variables in the Makefile, allow the up and downstream build processes for VM Op to be unified. Now the internal process can invoke the following to build VM Op from the upstream Makefile:
This patch also removes the GitHub jobs for building the manager and web console validator binaries as both are built as part of the "build-image" job.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: