Merge pull request #758 from akutz/feature/remove-var-reference

🌱 Remove vestigial kustomize var refs

config/certmanager/certificate.yaml

@@ -12,7 +12,7 @@ spec:
 apiVersion: cert-manager.io/v1
 kind: Certificate
 metadata:
-  name: serving-cert  # this name should match the one appeared in kustomizeconfig.yaml
+  name: serving-cert
   namespace: system
 spec:
   # WEBHOOK_SERVICE_NAME_PLACEHOLDER and WEBHOOK_SERVICE_NAMESPACE_PLACEHOLDER will be substituted by kustomize

config/certmanager/kustomization.yaml

@@ -1,5 +1,6 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
+
 resources:
 - certificate.yaml
 

config/certmanager/kustomizeconfig.yaml

@@ -1,19 +1,8 @@
-# This configuration is for teaching kustomize how to update name ref and var substitution 
+# nameReference teaches Kustomize which fields represent a resource name.
 nameReference:
 - kind: Issuer
   group: cert-manager.io
   fieldSpecs:
   - kind: Certificate
     group: cert-manager.io
     path: spec/issuerRef/name
-
-varReference:
-- kind: Certificate
-  group: cert-manager.io
-  path: spec/commonName
-- kind: Certificate
-  group: cert-manager.io
-  path: spec/dnsNames
-- kind: Certificate
-  group: cert-manager.io
-  path: spec/secretName

config/crd/kustomizeconfig.yaml

@@ -1,4 +1,4 @@
-# This file is for teaching kustomize how to substitute name and namespace reference in CRD
+# nameReference teaches Kustomize which fields represent a resource name.
 nameReference:
 - kind: Service
   version: v1
@@ -7,11 +7,9 @@ nameReference:
     group: apiextensions.k8s.io
     path: spec/conversion/webhook/clientConfig/service/name
 
+# namespace teaches Kustomize which fields represent a resource namespace.
 namespace:
 - kind: CustomResourceDefinition
   group: apiextensions.k8s.io
   path: spec/conversion/webhook/clientConfig/service/namespace
   create: false
-
-varReference:
-- path: metadata/annotations

config/default/kustomization.yaml

@@ -1,9 +1,6 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 
-configurations:
-- kustomizeconfig.yaml
-
 resources:
 - ../crd
 - ../manager

config/webhook/kustomizeconfig.yaml

@@ -1,5 +1,4 @@
-# the following config is for teaching kustomize where to look at when substituting vars.
-# It requires kustomize v2.1.0 or newer to work properly.
+# nameReference teaches Kustomize which fields represent a resource name.
 nameReference:
 - kind: Service
   version: v1
@@ -11,6 +10,7 @@ nameReference:
     group: admissionregistration.k8s.io
     path: webhooks/clientConfig/service/name
 
+# namespace teaches Kustomize which fields represent a resource namespace.
 namespace:
 - kind: MutatingWebhookConfiguration
   group: admissionregistration.k8s.io
@@ -20,6 +20,3 @@ namespace:
   group: admissionregistration.k8s.io
   path: webhooks/clientConfig/service/namespace
   create: true
-
-varReference:
-- path: metadata/annotations