Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support smoking test #8643

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue for Windows support found during smoking test

@Lyndon-Li Lyndon-Li added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (a9031eb) to head (43fcaa2).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8643      +/-   ##
==========================================
- Coverage   59.39%   59.39%   -0.01%     
==========================================
  Files         370      370              
  Lines       39952    39987      +35     
==========================================
+ Hits        23730    23750      +20     
- Misses      14731    14745      +14     
- Partials     1491     1492       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li marked this pull request as ready for review January 24, 2025 02:35
@blackpiglet
Copy link
Contributor

blackpiglet commented Jan 24, 2025

There are some KinD action failures in this PR.
All failures were related to v1.32.1 k8s KinD environment.
I found something related to this kubernetes-sigs/kind#3768
Those failures were not related to the Velero code change.

I think it's more related to v1.32.x KinD's contained version bumping.

@ywk253100 ywk253100 merged commit ec1eadc into vmware-tanzu:main Jan 24, 2025
43 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants