Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint: enable int-conversion and fiximports rule of perfsprint #8385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 8, 2024

Thank you for contributing to Velero!

Please add a summary of your change

enable int-conversion and fiximports rule of perfsprint
This is to reduce memory consumption

Does your change fix a particular issue?

No

Please indicate you've done the following:

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 8, 2024
@mmorel-35 mmorel-35 marked this pull request as ready for review November 8, 2024 22:07
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.96%. Comparing base (a46fef8) to head (6a96acd).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/backup/actions/csi/pvc_action.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8385   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files         367      367           
  Lines       38895    38893    -2     
=======================================
  Hits        22933    22933           
+ Misses      14500    14498    -2     
  Partials     1462     1462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ywk253100 ywk253100 requested a review from reasonerjt November 11, 2024 06:18
@blackpiglet blackpiglet added kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes and removed kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-2tests has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants