-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Kopia Backup to Local Volume Provider #8358
base: main
Are you sure you want to change the base?
Testing Kopia Backup to Local Volume Provider #8358
Conversation
ebf7caa
to
f43f79b
Compare
@kaovilai
|
It is aimed at #6197 mentioned. I'm going to be doing some testing in this area so figured I use this PR to write some notes down for potential design discussions. |
Making smallest change possible so hoping to not have to replace the local volume provider (LVP) object store plugin yet and aiming solely at enabling kopia usage from within velero code by detecting LVP and using bsl info for kopia. |
My goal is to enable ASAP testing of kopia performance via local volume as backup store. Once we have some ideas we can pursue long term vision around replacing LVP integration. So perhaps this design will just close and we'll open another. |
f43f79b
to
7749c35
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8358 +/- ##
=======================================
Coverage 58.95% 58.96%
=======================================
Files 367 367
Lines 38876 38886 +10
=======================================
+ Hits 22920 22928 +8
- Misses 14493 14495 +2
Partials 1463 1463 ☔ View full report in Codecov by Sentry. |
looks like there is already a filesystem store in the code so looking into that. var backendStores = []kopiaBackendStore{
{udmrepo.StorageTypeAzure, "an Azure blob storage", &backend.AzureBackend{}},
{udmrepo.StorageTypeFs, "a filesystem", &backend.FsBackend{}},
{udmrepo.StorageTypeGcs, "a Google Cloud Storage bucket", &backend.GCSBackend{}},
{udmrepo.StorageTypeS3, "an S3 bucket", &backend.S3Backend{}}, |
BSL needs to have backupLocation.Spec.Provider set to |
7749c35
to
56e6e71
Compare
56e6e71
to
9886256
Compare
replicated/lvp will handle pvc creation and mounting to nodeagents and hopefully the spice flows. |
9886256
to
7448a03
Compare
woot! thanks for pushing on this @kaovilai |
7448a03
to
812c631
Compare
812c631
to
7e6045a
Compare
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.