Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Contains or ErrorContains with testify #8322

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 18, 2024

Thank you for contributing to Velero!

Please add a summary of your change

use Contains or ErrorContains with testify

Does your change fix a particular issue?

It uses (assert|require).Contains(t,...) or (assert|require).ErrorContains(t, err,...) when possible
It also removes (assert|require).Error(t, err,...) as it is redundant with (assert|require).ErrorContains(t, err,...) behavior

Please indicate you've done the following:

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes labels Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (732b87b) to head (d06601e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8322      +/-   ##
==========================================
- Coverage   59.17%   58.99%   -0.19%     
==========================================
  Files         367      367              
  Lines       30849    38847    +7998     
==========================================
+ Hits        18256    22918    +4662     
- Misses      11130    14467    +3337     
+ Partials     1463     1462       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaovilai
Copy link
Contributor

Please close and reopen PRs

#8066

@anshulahuja98
Copy link
Collaborator

Hopefully this is okay to merge before 1.15 RC.

@reasonerjt reasonerjt merged commit c53ab20 into vmware-tanzu:main Oct 21, 2024
89 of 91 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/contains branch October 21, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants