Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(Makefile): add support for building container images for current-context cluster with ttl.sh registry and 24h TTL #8319

Closed

Conversation

kaovilai
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@kaovilai
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Oct 17, 2024
@kaovilai kaovilai closed this Oct 17, 2024
@kaovilai kaovilai reopened this Oct 17, 2024
@github-actions github-actions bot requested a review from sseago October 17, 2024 22:21
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (aab2140) to head (60aece1).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8319      +/-   ##
==========================================
- Coverage   59.21%   58.99%   -0.22%     
==========================================
  Files         367      367              
  Lines       30841    38847    +8006     
==========================================
+ Hits        18262    22918    +4656     
- Misses      11119    14467    +3348     
- Partials     1460     1462       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…t-context cluster with ttl.sh registry and 24h TTL

Signed-off-by: Tiger Kaovilai <[email protected]>
@blackpiglet
Copy link
Contributor

Could you give more information about the ttl.sh registry?

@kaovilai
Copy link
Contributor Author

kaovilai commented Oct 18, 2024

ttl.sh
Contributed by Replicated
Anonymous & ephemeral Docker image registry

Free to use. No need to sign-up. Open source.

How to use ttl.sh

  1. Tag your image with ttl.sh, a UUID, & time limit (i.e. :2h)

  2. Push your image

  3. Pull your image (before it expires)

@kaovilai
Copy link
Contributor Author

Follow up enhancements may add a target like so

install-current-context: container-current-context
	go run cmd/velero/velero.go install --image=<image-from-this-pr-target> --provider aws --bucket $AWS_BUCKET --prefix velero --plugins velero/velero-plugin-for-aws:latest --secret-file $AWS_SECRET_FILE

@kaovilai
Copy link
Contributor Author

the advantage is user who clone this repo do not need to docker login someregistry.io or create a repository to push to.

@blackpiglet
Copy link
Contributor

IMO, this change is making developing more convenient, but the ttl.sh is not a registry that can host the images for a long time, and I'm not sure whether ttl.sh is available for most environments, for example, I'm blocked from it by the firewall.

As a result, I suggest to keep this change as private.

@kaovilai
Copy link
Contributor Author

ack. you can always use your own registry and override with if that's preferable. or this can be modified to require your own registry. If that's desirable lmk. Closing for now.

@kaovilai kaovilai closed this Oct 22, 2024
kaovilai added a commit to kaovilai/dotfiles that referenced this pull request Nov 1, 2024
kaovilai added a commit to kaovilai/dotfiles that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants