-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(Makefile): add support for building container images for current-context cluster with ttl.sh registry and 24h TTL #8319
Conversation
/kind changelog-not-required |
eee08e1
to
5e4a920
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8319 +/- ##
==========================================
- Coverage 59.21% 58.99% -0.22%
==========================================
Files 367 367
Lines 30841 38847 +8006
==========================================
+ Hits 18262 22918 +4656
- Misses 11119 14467 +3348
- Partials 1460 1462 +2 ☔ View full report in Codecov by Sentry. |
…t-context cluster with ttl.sh registry and 24h TTL Signed-off-by: Tiger Kaovilai <[email protected]>
5e4a920
to
60aece1
Compare
Could you give more information about the |
ttl.sh Free to use. No need to sign-up. Open source.
|
Follow up enhancements may add a target like so install-current-context: container-current-context
go run cmd/velero/velero.go install --image=<image-from-this-pr-target> --provider aws --bucket $AWS_BUCKET --prefix velero --plugins velero/velero-plugin-for-aws:latest --secret-file $AWS_SECRET_FILE |
the advantage is user who clone this repo do not need to |
IMO, this change is making developing more convenient, but the As a result, I suggest to keep this change as private. |
ack. you can always use your own registry and override with if that's preferable. or this can be modified to require your own registry. If that's desirable lmk. Closing for now. |
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.