-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set hinting region to use for GetBucketRegion() in pkg/repository/config/aws.go #8297
base: main
Are you sure you want to change the base?
Conversation
7f8bfd3
to
d666c19
Compare
…fig/aws.go Signed-off-by: Tiger Kaovilai <[email protected]>
d666c19
to
69b456a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8297 +/- ##
==========================================
+ Coverage 59.18% 59.20% +0.01%
==========================================
Files 367 367
Lines 30838 30846 +8
==========================================
+ Hits 18253 18261 +8
- Misses 11124 11125 +1
+ Partials 1461 1460 -1 ☔ View full report in Codecov by Sentry. |
cc: @reasonerjt |
@shubham-pampattiwar @sseago @kaovilai LGTM, but shall we hold it after the branch is cut for v1.15? Unfortunately we see issues in the internal pipeline and still fixing it. |
@reasonerjt since this isn't a 1.15 regression (the bug is there in 1.14 as well), I don't think it's a 1.15 blocker. I'm fine with holding off until the branch is cut, and then we can target for 1.15.1. |
Sure |
Signed-off-by: Tiger Kaovilai [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #8296
Similar to vmware-tanzu/velero-plugin-for-aws#210
To test this PR, you would create aws BSL without region and attempt to backup using kopia/data mover
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.