Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral-storage documentation update for plugin requirements #8244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msfrucht
Copy link
Contributor

@msfrucht msfrucht commented Sep 24, 2024

Please add a summary of your change

I hit an interesting issue with ephemeral-storage as of late with OCP 4.16.

OCP and similar Kubernetes variations add ephemeral-storage to kubernetes resourceAllocations as options besides CPU and memory. Ignored in most Kubernetes clusters.

Previous versions of OCP did not notice ephemeral-storage usage from plugins as they are finished setting up in the container at startup time. As a result, ephemeral-storage could be set as low as limits of 25Mi or less.

With new installs, ephemeral-storage violations on installation. And eventually tracked down the issue to the /plugins directory.

These estimates are based on current object storage providers. It is entirely possible some plugins will exceed the estimated 100MB per plugin, but this seems to a comfortable estimate at current for some of the more common plugins.

From our own testing of Velero 1.14.1 object storage plugins and a couple of item transformation plugins.

sh-5.1$ du -h plugins/*
63M     plugins/kubevirt-velero-plugin <--- kubevirt item transformation plugin
83M     plugins/velero-plugin-for-aws <--- Amazon AWS object storage and snapshotter plugin
62M     plugins/velero-plugin-for-gcp <--- Google Cloud object storage and snapshotter plugin
52M     plugins/velero-plugin-for-microsoft-azure <-- Microsoft Azure storage and snapshotter plugin
91M     plugins/velero-plugins <--- OpenShift item transformation plugin
sh-5.1$ du -h  plugins 
348M    plugins

Does your change fix a particular issue?

Documentation for resolving ephemeral-storage plugin requirements seen in OpenShift 4.16 and any other Kubernetes cluster or environment that monitors and restricts ephemeral-storage usage.

Fixes #(issue)

Please indicate you've done the following:

/kind changelog-not-required

Signed-off-by: MICHAEL S FRUCHTMAN <[email protected]>
@msfrucht
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 24, 2024
@kaovilai
Copy link
Member

please force push and/or reopen pr to trigger changelog check due to issue.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@11f771f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8244   +/-   ##
=======================================
  Coverage        ?   59.20%           
=======================================
  Files           ?      367           
  Lines           ?    30838           
  Branches        ?        0           
=======================================
  Hits            ?    18259           
  Misses          ?    11119           
  Partials        ?     1460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfrucht msfrucht closed this Sep 24, 2024
@msfrucht msfrucht reopened this Sep 24, 2024
@msfrucht
Copy link
Contributor Author

@kaovilai I've corrected the issue. Would appreciate a review or I will just close this in another couple of months.

@kaovilai
Copy link
Member

Will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants