[WIP] Fix logrus-entry-contents when it is in hooks. #7037
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
In the issue #6187 , we found some strange behaviour of the logs output.
I add some test code for the logrus entry hook.
I found that when the first new the
NewTempFileLogger
and init thelogrus.Fields
, it works as expect.But when i override the value of
logrus.Fields
, it can not be works.Like the pics i test it.
Does your change fix a particular issue?
Fixes #6187
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.