Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get resource client again after restore actions in case resource's gv is changed #6634

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

27149chen
Copy link
Contributor

Please add a summary of your change

Get resource client again after restore actions in case resource's gv is changed.

This is an improvement of pr #6499, to support group changes. A group change usually happens in a restore plugin which is used for resource conversion: convert a resource from a not supported gv to a supported gv

Does your change fix a particular issue?

Fixes #6498

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #6634 (797267c) into main (a88cb46) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6634   +/-   ##
=======================================
  Coverage   60.18%   60.18%           
=======================================
  Files         242      242           
  Lines       25711    25712    +1     
=======================================
+ Hits        15474    15475    +1     
  Misses       9156     9156           
  Partials     1081     1081           
Files Changed Coverage Δ
pkg/restore/restore.go 64.32% <100.00%> (+0.02%) ⬆️

Signed-off-by: lou <[email protected]>
@reasonerjt reasonerjt merged commit 713792d into vmware-tanzu:main Aug 14, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore plugin for changing apiversion doesn't work
3 participants