Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement recreate ExistingResourcePolicy to restore API #6354
Implement recreate ExistingResourcePolicy to restore API #6354
Changes from all commits
447845d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 68 in config/crd/v1/bases/velero.io_restores.yaml
GitHub Actions / Run Codespell
Large diffs are not rendered by default.
Check failure on line 162 in design/Implemented/existing-resource-policy_design.md
GitHub Actions / Run Codespell
Check failure on line 165 in design/Implemented/existing-resource-policy_design.md
GitHub Actions / Run Codespell
Check failure on line 279 in design/Implemented/existing-resource-policy_design.md
GitHub Actions / Run Codespell
Check failure on line 119 in pkg/apis/velero/v1/restore_types.go
GitHub Actions / Run Codespell
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 200 in pkg/cmd/cli/restore/create.go
Codecov / codecov/patch
pkg/cmd/cli/restore/create.go#L200
Check warning on line 1629 in pkg/restore/restore.go
Codecov / codecov/patch
pkg/restore/restore.go#L1628-L1629
Check warning on line 1646 in pkg/restore/restore.go
Codecov / codecov/patch
pkg/restore/restore.go#L1639-L1646
Check warning on line 1650 in pkg/restore/restore.go
Codecov / codecov/patch
pkg/restore/restore.go#L1648-L1650
Check warning on line 1661 in pkg/restore/restore.go
Codecov / codecov/patch
pkg/restore/restore.go#L1652-L1661
Check warning on line 2566 in pkg/restore/restore.go
Codecov / codecov/patch
pkg/restore/restore.go#L2551-L2566
Check warning on line 2573 in pkg/restore/restore.go
Codecov / codecov/patch
pkg/restore/restore.go#L2569-L2573
Check warning on line 2582 in pkg/restore/restore.go
Codecov / codecov/patch
pkg/restore/restore.go#L2576-L2582
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the above polling timeout, it means the object still exists, then
resourceClient.Create
will definitely fail, so maybe we don't need to go with this try, but break by adding the error and explicitly saying that the deletion of the existing object failedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback!
Check warning on line 2598 in pkg/restore/restore.go
Codecov / codecov/patch
pkg/restore/restore.go#L2586-L2598