Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change addresses some updates to NSX Operator CRDs. NSX Operator has updated their API Group from "nsx.vmware.com" to "crd.nsx.vmware.com" for a handful of their CRDs - particularly related to VPCs. Additionally, a few CRDs have been removed/added. These CRDs are yet to be released, so there is no breaking change here.
NSX T1-based CRDs are unchanged.
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?:
Testing Done
Setup
I deployed a Supervisor with NSX VPC. I created a namespace with corresponding resources updated in this ConfigMap. Additionally,
subnetsets.crd.nsx.vmware.com
andnetworkinfos.crd.nsx.vmware.com
are already present by default. Finally, I installed Velero with this custom Velero vSphere Plugin.Tests
velero-vsphere-plugin-blocked-resources-list
successfully shows the resources I added in this PR.--details
view shows that no NSX CRDs are backed up.Errors: ... name: /pod-default message: /Error backing up item error: /error executing custom action (groupResource=subnetsets.crd.nsx.vmware.com, namespace=popularimages-ns, name=pod-default): rpc error: code = Unknown desc = Resource CRD subnetsets.crd.nsx.vmware.com is blocked in backup, skipping ...
Logs also indicated this: