Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add ut in Subnet/SubnetSet controllers related with SubnetConnectionBindingMaps" #987

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

wenyingd
Copy link
Contributor

@wenyingd wenyingd commented Jan 3, 2025

Reverts #964

Revert the UT change to rebase on ToT and resolve the conflict

Copy link
Contributor

@lxiaopei lxiaopei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhengxiexie zhengxiexie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (bbdbefb) to head (ab04fbc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #987   +/-   ##
=======================================
  Coverage   73.44%   73.44%           
=======================================
  Files         118      118           
  Lines       16367    16367           
=======================================
  Hits        12020    12020           
  Misses       3564     3564           
  Partials      783      783           
Flag Coverage Δ
unit-tests 73.44% <ø> (ø)

@wenyingd wenyingd merged commit 6f3e97f into main Jan 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants