Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-Pick]Add unit test in Subnet/SubnetSet controllers related with SubnetConnectionBindingMaps (#964) #985

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

wenyingd
Copy link
Contributor

@wenyingd wenyingd commented Jan 3, 2025

No description provided.

@wenyingd wenyingd changed the title [Cherry-Pick]Add unit test in Subnet/SubnetSet controllers related with SubnetConn… [Cherry-Pick]Add unit test in Subnet/SubnetSet controllers related with SubnetConnectionBindingMaps (#964) Jan 3, 2025
@wenyingd wenyingd requested review from yanjunz97 and lxiaopei January 3, 2025 06:49
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.76%. Comparing base (a57c8bd) to head (991f6a6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           v4.2.0     #985      +/-   ##
==========================================
+ Coverage   74.10%   74.76%   +0.65%     
==========================================
  Files         118      118              
  Lines       16361    16361              
==========================================
+ Hits        12125    12232     +107     
+ Misses       3456     3358      -98     
+ Partials      780      771       -9     
Flag Coverage Δ
unit-tests 74.76% <ø> (+0.65%) ⬆️

see 4 files with indirect coverage changes

@wenyingd
Copy link
Contributor Author

wenyingd commented Jan 7, 2025

/e2e

Copy link
Contributor

@lxiaopei lxiaopei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyingd wenyingd merged commit a3c5955 into vmware-tanzu:v4.2.0 Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants