Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unapproved ciphers TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 #972

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

zhengxiexie
Copy link
Contributor

@zhengxiexie zhengxiexie commented Dec 19, 2024

nsx-ncp uses 9981 port which supports the following ciphers:

 Port 9981
  Version: TLSv1.2
   TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256
   TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA
   TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA

TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 is not approved by BC

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.35%. Comparing base (a1693cd) to head (03d2ea8).

Files with missing lines Patch % Lines
cmd/main.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   73.37%   73.35%   -0.02%     
==========================================
  Files         118      118              
  Lines       16394    16398       +4     
==========================================
  Hits        12029    12029              
- Misses       3581     3585       +4     
  Partials      784      784              
Flag Coverage Δ
unit-tests 73.35% <0.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
cmd/main.go 0.00% <0.00%> (ø)

@zhengxiexie zhengxiexie merged commit 3117fdd into main Dec 24, 2024
3 checks passed
zhengxiexie added a commit that referenced this pull request Dec 24, 2024
[CP]Remove unapproved ciphers  TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256(#972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants